Jessica and Kayla Pull Request

[jwinchan]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	method signature, method block, return
What are the advantages of using git when collaboratively working on one code base?	Being able to upload our work into the github cloud and have a log of all the changes; and being able to pull from the updated master
What kind of relationship did you and your pair have with the unit tests?	It helped us keep organized. We were basically using a TDD method even before learning about TDD
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	We only used .each_pair for hashes and .each for arrays
What was one method you and your pair used to debug code?	We constantly saved our code and ran the rake test and debugged each failure or error. After the code was completed, we ran some game scenarios to further debug.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We had a discussion about preferred method of feedback (given that we're both from guess culture). We set a time limit for switching between driving and navigating.

[kaidamasaki]

Congratulations! Your code was really clear and easy to understand for the most part and in the places it got complicated I really liked how well your comments explained things.

Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	✔️ Commits from both of your machines too, great job!
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️ It sounds like you two worked really well together! 😃

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

[kaidamasaki]

Good use of sample!

[kaidamasaki]

Good use of "defensive" copying.