Adagrams Hanh / Sophia (Water)

[SoCodeDo]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	The outer 'shell' is made of 'def' and 'end' which first defines the method & then ends it. Next to def, is the name of the method. Then anything inside of 'def' and 'end' is the body of the method.
What are the advantages of using git when collaboratively working on one code base?	The biggest draw in using git is allowing teams to make changes by using branches. It also tracks the changes made to files making it easy to review past changes later on.
What kind of relationship did you and your pair have with the unit tests?	Hanh I believe has a better understanding of unit tests than I do. All our code was 'PASS' but it still is merky to me at least so it is something I need to spend more time reviewing and learning.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	An enumerable method was used on line 130 to sort words.
What was one method you and your pair used to debug code?	We debugged mostly by using the stack trace and individually/together meeting with TAs to help us better understand where we were going wrong in our code.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Code is not always going to be perfect, but if it is clean and it runs thats a win.

[kaidamasaki]

Great job! Your code was straightforward and clear.

Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	Please commit more often. It will be helpful for future projects.
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

[kaidamasaki]

It looks like this typo was added at in a last minute commit that wasn't tested.

Suggested change

	].feeze
	].freeze

[kaidamasaki]

Was this to work around something odd happening when you split things?

[kaidamasaki]

You can use chars here to be more explicit:

Suggested change

	word = word.split('')
	word = word.chars

[kaidamasaki]

It looks like you forgot to remove this debugging puts.