Open
Conversation
…its)...so I'm starting over. npm install complete
…oun, adverb, verb, adjective, noun). Player is able to fill out the six text input fields (can press submit and fields will clear). Placeholder text in each text input describes what to fill in.
… player and add each player's submission (poem lines) to the poem.
…k to submit the current poem line. current player number is now displayed.
…mitted poem line.
…sn't seem to be working
…ing in FinalPoem.test - this test was passing before when none of the text was acutally dispalyed :\
…ayers can keep submitting lines and the last line will be displayed. Once the poem is submitted the submission button and the most recent submisison dissapear
…led in - I really like this style
Author
|
A couple of tests failed, but the project seems to be working overall. I'd like to get some help/feedback on how to dry up the code, make better use of "fields," and what to do about the tests. |
CheezItMan
reviewed
Jan 16, 2021
CheezItMan
left a comment
There was a problem hiding this comment.
Overall not bad Aimee, you had things mostly working. See my comments on the FinalPoem.js file. Some of the other tests are failing because the tests are unable to select the correct input fields and enter text. They make assumptions about your code that is different.
Other than that you have a fully functional Exquisite Corpse game. Nice work. You did demonstrate the skills we were assessing.
Co-authored-by: Chris M <chris@adadevelopersacademy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection