Conversation
…ot a function ???
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Stacy, you have a fully functional Exquisite corpse game and you got all the tests to pass. Well done.
See my notes on the stringFormat and some of the warnings you're getting.
| PlayerSubmissionForm.propTypes = { | ||
| index: PropTypes.number.isRequired, | ||
| sendSubmission: PropTypes.func.isRequired, | ||
| isSubmitted: PropTypes.bool.isRequired, |
There was a problem hiding this comment.
Just a note, that because you've added this prop the tests are giving a warning because the tests aren't using. If you add that prop to the tests, the warning will stop.
| submission: PropTypes.string.isRequired, | ||
| isSubmitted: PropTypes.bool.isRequired, |
There was a problem hiding this comment.
Also if you're not using submission as a prop, you should change it. You're getting a warning because this is required, but you're not using it.
|
|
||
| <p className="Game__format-example"> | ||
| { exampleFormat } | ||
| { stringFormat } |
There was a problem hiding this comment.
stringFormat is a function here, so you can't render it. I'm not sure what this is supposed to do.
2 participants
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection