Fire | Ayesha - Exquisite react submission#43
Open
ayaseef wants to merge 8 commits intoAda-C14:masterfrom
Open
Fire | Ayesha - Exquisite react submission#43ayaseef wants to merge 8 commits intoAda-C14:masterfrom
ayaseef wants to merge 8 commits intoAda-C14:masterfrom
Conversation
CheezItMan
reviewed
Jan 16, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Ayesha, you have a fully functional Exquisite corpse game and you got almost all the tests to pass. Well done.
The one test failing makes an assumption based on the index prop. You can see it on line 96 of PlayerSubmissionForm.test.js That's why it's failing.
| return ( | ||
| <div className="PlayerSubmissionForm"> | ||
| <h3>Player Submission Form for Player #{ }</h3> | ||
| <h3>Player Submission Form for Player #{player}</h3> |
There was a problem hiding this comment.
Just a note, that the test assumes the index prop determines which player's turn it is. That's why that test is failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection