Water @ Hanh Solo Exquisite React Submission#46
Water @ Hanh Solo Exquisite React Submission#46seattlefurby17 wants to merge 8 commits intoAda-C14:masterfrom
Conversation
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Hanh, you have a fully functional Exquisite corpse game. Well done.
You do have some tests failing and I tried to note what could be done to fix them. The biggest thing is some of the props were changed in components, but not in the tests.
| @@ -3,13 +3,17 @@ import PropTypes from 'prop-types'; | |||
| import './RecentSubmission.css'; | |||
|
|
|||
| const RecentSubmission = (props) => { | |||
There was a problem hiding this comment.
Just to note the tests for this component are passing, so you didn't need to skip them.
| @@ -0,0 +1,46 @@ | |||
| const FinalPoem = (props) => { | |||
There was a problem hiding this comment.
I'm not sure what this file is for.
| @@ -3,23 +3,36 @@ import PropTypes from 'prop-types'; | |||
| import './FinalPoem.css'; | |||
|
|
|||
| const FinalPoem = (props) => { | |||
There was a problem hiding this comment.
Just a note that it looks like the tests are failing because you used different props like isRevealed instead of isSubmitted. That's why it looks like the tests are failing.
| <h3>Player Submission Form for Player #{ }</h3> | ||
|
|
||
| <form className="PlayerSubmissionForm__form" > | ||
| <h3>Player Submission Form for Player # { props.index }</h3> |
There was a problem hiding this comment.
This will cause all the tests in Game.test.js to pass.
| <h3>Player Submission Form for Player # { props.index }</h3> | |
| <h3>Player Submission Form for Player #{ props.index }</h3> |
2 participants
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection