Open
Conversation
CheezItMan
reviewed
May 20, 2021
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Alice. I did have a few comments on time complexity. Let me know if you have any questions regarding it. WEll done.
Comment on lines
+4
to
7
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def grouped_anagrams(strings) |
There was a problem hiding this comment.
👍 Nice work, just a note if the strings are limited in size, the time complexity is O(n), otherwise it is O(n * m log m) where n is the number of strings and m is the length of the strings.
Comment on lines
+29
to
31
| # Time Complexity: O(n^2) because of the .sort_by used mid method | ||
| # Space Complexity: O(n) | ||
| def top_k_frequent_elements(list, k) |
There was a problem hiding this comment.
👍 Because you're sorting the (and not in a loop) your algorithm is O(n log n) because Ruby uses MergeSort internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions