-
Notifications
You must be signed in to change notification settings - Fork 37
Earth - Olga #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Earth - Olga #19
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,18 @@ | ||
|
|
||
| require_relative "min_heap" | ||
|
|
||
| # This method uses a heap to sort an array. | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def heap_sort(list) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| # Time Complexity: O(n log n) | ||
| # Space Complexity: O(n) | ||
| def heapsort(list) | ||
| result = [] | ||
| heap = MinHeap.new | ||
| list.each do |element| | ||
| heap.add(element) | ||
| end | ||
|
|
||
| until heap.empty? | ||
| result << heap.remove | ||
| end | ||
|
|
||
| return result | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,18 +14,22 @@ def initialize | |
| end | ||
|
|
||
| # This method adds a HeapNode instance to the heap | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(n) | ||
| def add(key, value = key) | ||
|
Comment on lines
+17
to
19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Why O(n) for space complexity, you add 1 element with this method. |
||
| raise NotImplementedError, "Method not implemented yet..." | ||
| @store << HeapNode.new(key, value) | ||
| heap_up(@store.length - 1) | ||
| end | ||
|
|
||
| # This method removes and returns an element from the heap | ||
| # maintaining the heap structure | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def remove() | ||
|
Comment on lines
+26
to
28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 However for space complexity it's O(log n) because of the call stack. |
||
| raise NotImplementedError, "Method not implemented yet..." | ||
| swap(0, @store.length - 1) | ||
| removed_element = @store.pop | ||
| heap_down(0) | ||
| return removed_element.value | ||
| end | ||
|
|
||
|
|
||
|
|
@@ -44,28 +48,46 @@ def to_s | |
| end | ||
|
|
||
| # This method returns true if the heap is empty | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(1) | ||
| # Space complexity: O(1) | ||
| def empty? | ||
|
Comment on lines
+51
to
53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| raise NotImplementedError, "Method not implemented yet..." | ||
| return @store.length == 0 | ||
| end | ||
|
|
||
| private | ||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap, if it is less than it's parent node. | ||
| # It could be **very** helpful for the add method. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(log n) | ||
| # Space complexity: O(1) | ||
| def heap_up(index) | ||
|
Comment on lines
+62
to
64
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 , but your space complexity is off due to recursion |
||
|
|
||
| return if index == 0 | ||
| parent_index = (index - 1) / 2 | ||
| if @store[index].key < @store[parent_index].key | ||
| swap(index, parent_index) | ||
| heap_up(parent_index) | ||
| end | ||
| end | ||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap if it's smaller | ||
| # than it's parent node. | ||
| def heap_down(index) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| left_child = (index * 2) + 1 | ||
| right_child = (index * 2) + 2 | ||
|
|
||
| return if @store[left_child].nil? || @store[right_child].nil? | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about if the left child is not Could you end up not making a swap you needed to? This is a rare but possible scenario. |
||
|
|
||
| if @store[index].key > @store[left_child].key | ||
| swap(index, left_child) | ||
| heap_down(left_child) | ||
| end | ||
|
|
||
| if @store[index].key > @store[right_child].key | ||
| swap(index, right_child) | ||
| heap_down(right_child) | ||
| end | ||
| end | ||
|
|
||
| # If you want a swap method... you're welcome | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍