Skip to content

Stacy's Pull Request#34

Open
StacyLundquist wants to merge 15 commits intoAda-C14:masterfrom
StacyLundquist:master
Open

Stacy's Pull Request#34
StacyLundquist wants to merge 15 commits intoAda-C14:masterfrom
StacyLundquist:master

Conversation

@StacyLundquist
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The model is like the class, it keeps the back data.
Describe in your own words what the Controller is doing in Rails The controller is like the method(s), it takes the data and responds to the client.
Describe in your own words what the View is doing in Rails The view controls what everything looks like, display/HTML.
Describe an edge-case controller test you wrote Expecting the path to redirect if an invalid ID is entered into 'update'
What is the purpose of using strong params? (i.e. the params method in the controller) It help controls whether others can use the parameters to change the forms (for nefarious or other reasons).
How are Rails migrations related to Rails models? A migration changes the database schema itself, and stores information about what the model is describing; whereas the model is the 'class', it keeps the data.
Describe one area of Rails that are still unclear on Knowing where to find the location of all of the files. Resoures having two update routes that look identical, creating prefixes for all of the routes.

@jmaddox19
Copy link

TaskList Feedback

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️ Yes! Though messages could be a bit longer and more specific
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views ✔️ I enjoy the little bubbles :)
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Edit, Update tests pass with valid & invalid task ids ✔️
Successfully handles: Destroy, Task Complete ✔️
Tests for Destroy & Task Complete include tests for valid and invalid task ids Yes for Destroy but not for Task Complete or Incomplete

Overall Feedback

Great work! You made a fully-functional multi-page Ruby on Rails website!!! In just a week!

And all the code is easy to read and understand! 👏👏👏

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 6+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants