Skip to content

Fire - Aimee#43

Open
marks214 wants to merge 18 commits intoAda-C14:masterfrom
marks214:master
Open

Fire - Aimee#43
marks214 wants to merge 18 commits intoAda-C14:masterfrom
marks214:master

Conversation

@marks214
Copy link

@marks214 marks214 commented Nov 2, 2020

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The Model in Rails is a class that corresponds to a database table.
Describe in your own words what the Controller is doing in Rails The Controller receives a specific action request for the application from the routes.
Describe in your own words what the View is doing in Rails The View displays information from the Controller.
Describe an edge-case controller test you wrote For the delete/destroy tests, if a task that doesn't exist is given, then the task count doesn't change and the user will be redirected to the root path.
What is the purpose of using strong params? (i.e. the params method in the controller) Strong params are useful to DRY up code for the create and update actions. When trying to pass all the data from params directly without listing out each individual field, Rails will give an ActiveModel::ForbiddenAttributesError for security unless strong params (private method section with permitted parameters) is given.
How are Rails migrations related to Rails models? Rails migrations allow you to change database table information.
Describe one area of Rails that are still unclear on Several things: find vs. find_by, route "as:" naming conventions (e.g., tasks, task, new_task, etc.), how to do strike-through to make the tasks appear completed, how to confirm if the user wants to delete a task, using a pop-up, using buttons instead of links, applying CSS to style the tasks-list project

@jmaddox19
Copy link

TaskList Feedback

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views No styling
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Edit, Update tests pass with valid & invalid task ids ✔️
Successfully handles: Destroy, Task Complete ✔️
Tests for Destroy & Task Complete include tests for valid and invalid task ids Yes for Destroy but not for Task Complete

Overall Feedback

Great work! You made a fully-functional multi-page Ruby on Rails website!!! In just a week!

And all the code is easy to read and understand! 👏👏👏

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 6+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants