Skip to content

Fire - Alice D#45

Open
codeandmorecode wants to merge 19 commits intoAda-C14:masterfrom
codeandmorecode:master
Open

Fire - Alice D#45
codeandmorecode wants to merge 19 commits intoAda-C14:masterfrom
codeandmorecode:master

Conversation

@codeandmorecode
Copy link

@codeandmorecode codeandmorecode commented Nov 3, 2020

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails It's a ruby class that can add database records, find particular data, update data, or remote data.
Describe in your own words what the Controller is doing in Rails The controller makes sense of the requests and produces the appropriate output
Describe in your own words what the View is doing in Rails It is html with embedded ruby and compiles the response from the Controller
Describe an edge-case controller test you wrote An example of an edge case includes testing any method with a task id of -1
What is the purpose of using strong params? (i.e. the params method in the controller) The purpose of using strong params is to dry up your code and for security reasons
How are Rails migrations related to Rails models? When you use rails to generate a model, a migration is generated as well, and that is because a migration is a change to the database schema
Describe one area of Rails that are still unclear on One area I am still unclear on is where to find the info about the structure of our data within my program

@jmaddox19
Copy link

TaskList Feedback

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views No styling
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Edit, Update tests pass with valid & invalid task ids ✔️
Successfully handles: Destroy, Task Complete ✔️
Tests for Destroy & Task Complete include tests for valid and invalid task ids Yes for Destroy but no for Task Complete

Overall Feedback

Great work! You made a fully-functional multi-page Ruby on Rails website!!! In just a week!

And all the code is easy to read and understand! 👏👏👏

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 6+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants