Fire: Blaine: Task-

[Blaine206]

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	A model is a class that handles data and allows you to manipulate data.
Describe in your own words what the Controller is doing in Rails	Controller has the methods that deal with the data in the database.
Describe in your own words what the View is doing in Rails	View is what renders a page on the browser.
Describe an edge-case controller test you wrote
What is the purpose of using strong params? (i.e. the params method in the controller)	Dry's up the code.
How are Rails migrations related to Rails models?	Migration determines what information is rendered in the models.
Describe one area of Rails that are still unclear on	Tests, paths, ways to expand on checks, buttons, forms, code(does this need javascript)?

[jmaddox19]

TaskList Feedback

Task List

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages	Definitely encourage you to commit more frequently :)
Routes follow RESTful conventions	✔️
Uses named routes (like _path)	✔️
Creates Models and migrations	✔️
Creates styled views	No styling
Handles errors like nonexistant tasks	✔️
Uses form_with to render forms in Rails	✔️

Functional Requirements/Manual Testing

Functional Requirement	yes/no
Successfully handles index & show	After creating a task, when I navigate back to the index page, I get the following error undefined method 'localtime' for nil:NilClass. Also it's awkward for the user that there's no link from the homepage to create a new tasks. As a user, I needed to know to type in /tasks/new in the url to be able to create a new Task.
index & show tests pass	✔️
Successfully handles: New, Create	✔️
New, Create tests pass	✔️
Successfully handles: Edit, Update	✔️
Edit, Update tests pass with valid & invalid task ids	✔️
Successfully handles: Destroy, Task Complete	There is a completed_at action but there's no way for the user to trigger it from the browser because there's no button or link pointing to it.
Tests for Destroy & Task Complete include tests for valid and invalid task ids

Overall Feedback

Congrats! You made your first Rails website!

Based on some of the odd things I noticed, I'm wondering if perhaps your workflow for this project didn't include testing the server manually. In addition to unit tests, testing out the site you're working on manually as if you were a user is an important part of the development process, especially now that we're into web development. Plus, messing around with your own website is just fun!

And all the code is easy to read and understand! 👏👏👏 If anything, I would say you can feel ok about having less comments than you currently do. I'm happy to talk more about that in our 1:1 next week if that'd be helpful :)

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	5+ in Code Review && 6+ in Functional Requirements
Yellow (Approaches Standards)	3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention	✔️
Red (Not at Standard)	0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention