Skip to content

water-marj#54

Open
Schmarj3 wants to merge 5 commits intoAda-C14:masterfrom
schmarj3-learning-projects:master
Open

water-marj#54
Schmarj3 wants to merge 5 commits intoAda-C14:masterfrom
schmarj3-learning-projects:master

Conversation

@Schmarj3
Copy link

@Schmarj3 Schmarj3 commented Nov 3, 2020

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails the model holds the blue print for the data and any non-website related logic
Describe in your own words what the Controller is doing in Rails the controller provides route destination logic and gets info from the Active Record and passed info to the view
Describe in your own words what the View is doing in Rails the view is what the user interacts with
Describe an edge-case controller test you wrote if a user tries to edit/update/destroy a task that doesn't exist, it should redirect the user to the 'homepage'
What is the purpose of using strong params? (i.e. the params method in the controller) need to review this before giving a response to this question
How are Rails migrations related to Rails models? when we make changes to a model, we need to do a change migration so the database will be updated with the changes
Describe one area of Rails that are still unclear on syntax, variables, strong params, all of it

Copy link

@kaidamasaki kaidamasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! You've made a Rails app!

It's on the small side but that doesn't make it any less impressive!

Congrats! You're now a full stack developer!

(Also, even though you didn't finish Wave 4 you did get pretty close. 😃)

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages Please try to commit more frequently in the future.
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views No custom CSS.
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Edit, Update tests pass with valid & invalid task ids ✔️
Successfully handles: Destroy, Task Complete Marking complete fails.
Tests for Destroy & Task Complete include tests for valid and invalid task ids No tests for marking complete.

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 6+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants