Skip to content

Fire - Madeline#57

Open
made-line wants to merge 7 commits intoAda-C14:masterfrom
made-line:master
Open

Fire - Madeline#57
made-line wants to merge 7 commits intoAda-C14:masterfrom
made-line:master

Conversation

@made-line
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails Model contains data/state of application.
Describe in your own words what the Controller is doing in Rails Controller gathers data from the model and handles HTTP requests.
Describe in your own words what the View is doing in Rails View displays data to end user.
Describe an edge-case controller test you wrote
What is the purpose of using strong params? (i.e. the params method in the controller)
How are Rails migrations related to Rails models? Migrations are changes to the database and blueprint for how the model stores data.
Describe one area of Rails that are still unclear on

Copy link

@beccaelenzil beccaelenzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️ You have the appropriate number of commits for the amount of work :)
Routes follow RESTful conventions ✔️
Uses named routes (like _path) incomplete
Creates Models and migrations ✔️
Creates styled views not required
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails incomplete

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass see inline comment for the root path, the test expect the show action to redirect for invalid id -- in the controller action you return a 404
Successfully handles: New, Create incomplete
New, Create tests pass incomplete
Successfully handles: Edit, Update incomplete
Edit, Update tests pass with valid & invalid task ids incomplete
Successfully handles: Destroy, Task Complete incomplete
Tests for Destroy & Task Complete include tests for valid and invalid task ids incomplete

Overall Feedback

You are off to a great start on this project! We can talk in our 1:1 about whether revisiting this project or moving in with future rails projects will best support your learning.

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 6+ in Functional Requirements
Yellow (Approaches Standards) 3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention ✔️

config/routes.rb Outdated
@@ -0,0 +1,5 @@
Rails.application.routes.draw do
get '/tasks', to: 'tasks#index', as: 'tasks'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how you add a root path so that localhost:3000 points to the task index page.

Suggested change
get '/tasks', to: 'tasks#index', as: 'tasks'
root to: 'tasks#index'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants