Skip to content

Earth-Maha#58

Open
Maha-ElMais wants to merge 2 commits intoAda-C14:masterfrom
Maha-ElMais:master
Open

Earth-Maha#58
Maha-ElMais wants to merge 2 commits intoAda-C14:masterfrom
Maha-ElMais:master

Conversation

@Maha-ElMais
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails the model adds a database that can be accessed and manipulated
Describe in your own words what the Controller is doing in Rails the controller coordinates the interaction between the user, the views, and the model. It routes external requests to internal actions.
Describe in your own words what the View is doing in Rails an embedded ruby html file that allows to render the view of a controller
Describe an edge-case controller test you wrote will redirect for an invalid task"
What is the purpose of using strong params? (i.e. the params method in the controller) it is like a helper method that makes it so we don't have to populate the fields every time.
How are Rails migrations related to Rails models? every time the model is updated we run rails migrate to make sure we have the latest version of the database
Describe one area of Rails that are still unclear on partial views

Copy link

@kaidamasaki kaidamasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't do Wave 4 and you had some bugs but overall your code looks pretty reasonable but it's clear you ran out of time to debug.

If you get stuck like this again will you try to reach out sooner so we can make sure to get past where you're stuck?

I think you met most of the learning goals as the Major Learning Goals/Code Review section shows so I feel like this ought to be a yellow assignment, even though the rubric pushes it to red.

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages Please commit more frequently while you're working. This will really help when we do the group project.
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views No custom CSS.
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass
Successfully handles: Edit, Update
Edit, Update tests pass with valid & invalid task ids
Successfully handles: Destroy, Task Complete
Tests for Destroy & Task Complete include tests for valid and invalid task ids

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 6+ in Functional Requirements
Yellow (Approaches Standards) 3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention ✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

redirect_to root_path # see the task in the index list
return
else # save failed
render :new, status: :bad_request # show the new task form view again

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of status with render. 😃

This line should be indented though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants