Water@Hanh Solo - Tree practices#34
Open
seattlefurby17 wants to merge 2 commits intoAda-C14:masterfrom
Open
Conversation
CheezItMan
reviewed
May 3, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Thanks for getting this in Hanh. It's clear you found this project challenging. I left some comments, I hope you find helpful. Let me know what questions you have and I'm happy to work with you on this one.
lib/tree.rb
Outdated
Comment on lines
33
to
37
| if key < current_node.key | ||
| current_node = current_node.left | ||
| else | ||
| current_node = current_node.right | ||
| end |
There was a problem hiding this comment.
What if key and current_node.key are equal?
lib/tree.rb
Outdated
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def inorder(current_node = @root, answer = []) | ||
| return [] if current_node.nil? |
There was a problem hiding this comment.
Suggested change
| return [] if current_node.nil? | |
| return answer if current_node.nil? |
lib/tree.rb
Outdated
| @root = new_node | ||
| else | ||
| current_node = @root | ||
| previouse_node = @root |
lib/tree.rb
Outdated
| # Space Complexity: O(1) | ||
| def find(key) | ||
| raise NotImplementedError | ||
| def find_helper(key, current_node) |
There was a problem hiding this comment.
Making an inner method like this in Ruby is discouraged and messy. It leads to tree.rb:54: warning: method redefined; discarding old find_helper
Comment on lines
23
to
47
| new_node = TreeNode.new(key, value) | ||
|
|
||
| if @root == nil | ||
| @root = new_node | ||
| else | ||
| current_node = @root | ||
| previouse_node = @root | ||
|
|
||
| while current_node != nil | ||
| previouse_node = current_node | ||
| if key < current_node.key | ||
| current_node = current_node.left | ||
| else | ||
| current_node = current_node.right | ||
| end | ||
|
|
||
| if key < previouse_node.key | ||
| previouse_node.left = new_node | ||
| else | ||
| previouse_node.right = new_node | ||
| end | ||
| end | ||
|
|
||
| return new_node | ||
| end |
There was a problem hiding this comment.
Suggested change
| new_node = TreeNode.new(key, value) | |
| if @root == nil | |
| @root = new_node | |
| else | |
| current_node = @root | |
| previouse_node = @root | |
| while current_node != nil | |
| previouse_node = current_node | |
| if key < current_node.key | |
| current_node = current_node.left | |
| else | |
| current_node = current_node.right | |
| end | |
| if key < previouse_node.key | |
| previouse_node.left = new_node | |
| else | |
| previouse_node.right = new_node | |
| end | |
| end | |
| return new_node | |
| end | |
| new_node = TreeNode.new(key, value) | |
| if @root == nil | |
| @root = new_node | |
| else | |
| current_node = @root | |
| previous_node = @root | |
| until current_node.nil? | |
| previous_node = current_node | |
| if key < current_node.key | |
| current_node = current_node.left | |
| else | |
| current_node = current_node.right | |
| end | |
| end | |
| if key < previous_node.key | |
| previous_node.left = new_node | |
| else | |
| previous_node.right = new_node | |
| end | |
| return new_node | |
| end | |
| end |
lib/tree.rb
Outdated
| if current_node | ||
| inorder(current_node.left, answer) | ||
| answer.push({key: current_node.key, value: current_node.value}) | ||
| inorder(current_node.right) |
There was a problem hiding this comment.
Suggested change
| inorder(current_node.right) | |
| inorder(current_node.right, answer) |
lib/tree.rb
Outdated
Comment on lines
90
to
91
| preorder(current_node.right, answer) | ||
| preorder(current_node.left) |
Comment on lines
+109
to
+111
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def height(current_node = @root) |
There was a problem hiding this comment.
👍 However your space complexity is O(n) only if the tree is unbalanced and O(log n) if it is balanced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.