Open
Conversation
Author
|
final push |
|
Grabbing this to grade! |
chimerror
reviewed
Jul 28, 2022
chimerror
left a comment
chimerror
left a comment
There was a problem hiding this comment.
Good work!
I added some comments about unneeded import statements, left-in debugging code, and missing complexity calculations on your top-K solution, but overall this looks good enough for a Green!
|
|
||
| from array import array | ||
| from distutils.log import error | ||
| import string |
There was a problem hiding this comment.
It looks like these import statements didn't get used (they were probably added by an overzealous IDE), so you can remove them
| """ | ||
| pass | ||
| print(top_k_frequent_elements([1, 2, 2, 2, 3, 3, 3], 2)) No newline at end of file |
There was a problem hiding this comment.
Make sure to remove testing code like this before checking in, just to keep the code clean for style purposes.
| """ This method will return the k most common elements | ||
| In the case of a tie it will select the first occuring element. | ||
| Time Complexity: ? | ||
| Space Complexity: ? |
There was a problem hiding this comment.
Looks like the complexity calculations got missed here, but I haven't been dinging people for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions