Open
Conversation
kyra-patton
reviewed
Jun 1, 2022
kyra-patton
left a comment
There was a problem hiding this comment.
✨💫 Very nice! I left a few comments on space complexity below. Let me know what questions you have.
🟢
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n log n) | ||
| Space Complexity: O(n) |
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) | ||
| Space Complexity: O(1) |
There was a problem hiding this comment.
✨ Nice, however the space complexity is O(log n) because of the recursive call stack of heap_up
| maintaining the heap structure | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) |
There was a problem hiding this comment.
✨ Nice, however like above, space complexity is O(log n) because of the recursive call stack of heap_down
| @@ -44,10 +66,10 @@ def __str__(self): | |||
|
|
|||
| def empty(self): | |||
| Time complexity: ? | ||
| Space complexity: ? | ||
| Time complexity: O(log n) | ||
| Space complexity: makes a recursive call |
There was a problem hiding this comment.
✨ What does the recursive call imply the space complexity should be??
| #continue to heap_up until the root is reached and every node ordered correctly | ||
| self.heap_up(parent) | ||
|
|
||
| def heap_down(self, index): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?