Open
Conversation
kyra-patton
reviewed
Jun 2, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
💫 Great job Areeba! I left a couple comments on complexity. Let me know what questions you have.
🟢
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: n log n | ||
| Space Complexity: n |
There was a problem hiding this comment.
✨ Nice! How might you implement this using the MinHeap you created below?
| self.store[index_1] = self.store[index_2] | ||
| self.store[index_2] = temp | ||
|
|
||
| def parent_idx(self, index): |
Comment on lines
+102
to
+103
| left = index * 2 + 1 | ||
| right = index * 2 + 2 |
| """ This helper method takes an index and | ||
| moves the corresponding element down the heap if it's | ||
| larger than either of its children and continues until | ||
| the heap property is reestablished. |
| Time complexity: ? | ||
| Space complexity: ? | ||
| Time complexity: log n | ||
| Space complexity: 1 |
There was a problem hiding this comment.
✨ Nice, however because of the recursive call stack, space complexity is O(log n) here
| Time complexity: ? | ||
| Space complexity: ? | ||
| Time complexity: 1 | ||
| Space complexity: 1 |
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: log n | ||
| Space Complexity: 1 |
There was a problem hiding this comment.
✨ Nice, however because of the recursive call stack of heap_down, space complexity is also O(log n)
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: log n | ||
| Space Complexity: 1 |
There was a problem hiding this comment.
✨ Because of the recursive call stack of heap_up space complexity is O(log n) here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?