Open
Conversation
kyra-patton
reviewed
Jun 28, 2022
kyra-patton
left a comment
There was a problem hiding this comment.
✨💫 Excellent implementation!
For the comprehension questions:
How is a Heap different from a Binary Search Tree? --> You answered that heaps are unordered. Heaps are _semi_ordered. Parents must be bigger/smaller (depending on whether it's a max/min heap) than each of their children.
Could you build a heap with linked nodes? --> You said no. It is possible, but it's not the most efficient way to implement it because of all the insertion/deletion and tracking parents/children.
Let me know what questions you have.
🟢
| """ This method uses a heap to sort an array. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n log n)? |
Comment on lines
+22
to
+23
| Time Complexity: O(log n)? | ||
| Space Complexity: O(log n)? (the recursive stack space, if done iteratively it's constant space) |
There was a problem hiding this comment.
💫 Very nice! Most folks don't catch the space complexity there.
| maintaining the heap structure | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n)? |
| """ This method returns true if the heap is empty | ||
| Time complexity: ? | ||
| Space complexity: ? | ||
| Time complexity: constant ? |
| Time complexity: ? | ||
| Space complexity: ? | ||
| Time complexity: O(log n) ? | ||
| Space complexity: O(log n) ? |
| moves the corresponding element down the heap if it's | ||
| larger than either of its children and continues until | ||
| the heap property is reestablished. | ||
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?