Open
Conversation
kyra-patton
reviewed
Jul 28, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
✨ Hi Sabrina, I have some concerns about your implementation and you missed implementing the last required function reverse. Take a look at my comments and let me know what questions you have.
🟡
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length(self): |
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: 0(1) | ||
| def get_at_index(self, index): |
Comment on lines
+118
to
+123
| index = 0 | ||
| current = self.head | ||
| prev = self.head | ||
| temp = self.head | ||
| while current is not None: | ||
| if index == value: |
There was a problem hiding this comment.
Same thing here you are checking to see if the node's value attribute is equal to the passed in value, not to see whether value equals the index of the node.
| while current is not None: | ||
| if index == value: | ||
| temp = current.next | ||
| break |
There was a problem hiding this comment.
🤓 We generally like to avoid break statements where possible. How might you refactor your code to eliminate this break statement?
| current = current.next | ||
| index += 1 | ||
| prev.next = temp | ||
| return prev |
There was a problem hiding this comment.
It's not necessary to return anything for this function
Suggested change
| return prev |
Comment on lines
+133
to
+134
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) |
Comment on lines
-89
to
-92
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def reverse(self): | ||
| pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.