Conversation
|
Grabbing this to grade! |
chimerror
left a comment
chimerror
left a comment
There was a problem hiding this comment.
Good work!
I added some notes about a small performance issue with your recursive implementation of adding nodes, as well as a comment about leaving old code around, but overall this is good enough for a Green!
| else: | ||
| current_root.right = self.add_helper(current_root.right, new_node) | ||
|
|
||
| return current_root |
There was a problem hiding this comment.
This implementation of add_helper works, but definitely does a bit of extra work in setting nodes. Essentially, every node on the path to where the new node ends up will have either its left or right node "updated", though most of these will be updated to the exact same node. The only one that gets a meaningful update is whenever the bottom of the tree is reached and gets its left/right node updated to the new node. These updates happen in lines 20 and 23.
This probably will not be too bad of a performance hit, but there is a way that you can do this and just update only the node you need.
But this overall fine enough!
| return | ||
|
|
||
| new_node = TreeNode(key, value) | ||
| self.add_helper(self.root, new_node) |
There was a problem hiding this comment.
Looks like this was an older recursive solution. Good on you for solving it both ways! And correctly at that!
However, do be careful about leaving old unused versions of code in your source code, whether they are commented out or not. Especially if they have have the same name as they do in this case. Just mainly a style thing about aiming to keep your code clean of clutter.
2 participants
No description provided.