Open
Conversation
|
Grabbing this to grade! |
chimerror
reviewed
Jun 10, 2022
chimerror
left a comment
chimerror
left a comment
There was a problem hiding this comment.
Good Work!
I added a comment about some commented code and your space complexity calculation for height, but this is good enough for a Green!
| # Space Complexity: | ||
| # def add(self, key, value = None): | ||
| # # base case | ||
| # if not current.left and not current.right: |
There was a problem hiding this comment.
Not a big deal, but generally I recommend removing unfinished but uncommented code like this to just keep the source clean as a style thing.
|
|
||
|
|
||
| # Time Complexity: O(n) and n = # of nodes in BST | ||
| # Space Complexity: O(n) ? not sure on this one |
There was a problem hiding this comment.
Good news, neither are the instructors, because as I was doing this grading I realized our instructor solution was wrong on these calculations! In this case as there is no additional space allocated, I would consider this O(1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.