Conversation
|
Grabbing this to grade! |
chimerror
left a comment
chimerror
left a comment
There was a problem hiding this comment.
Good work!
I added a comment about your add_helper implementation having a slight performance problem, but everything else looks fine enough for a Green.
| curr.left = self.add_helper(curr.left, new_node) | ||
| else: | ||
| curr.right = self.add_helper(curr.right, new_node) | ||
| return curr |
There was a problem hiding this comment.
This implementation of add_helper works, but definitely does a bit of extra work in setting nodes. Essentially, every node on the path to where the new node ends up will have either its left or right node "updated", though most of these will be updated to the exact same node. The only one that gets a meaningful update is whenever the bottom of the tree is reached and gets its left/right node updated to the new node. These updates happen in lines 31 and 32.
This probably will not be too bad of a performance hit, but there is a way that you can do this and just update only the node you need.
But this overall fine enough!
2 participants
No description provided.