Conversation
kyra-patton
reviewed
Jul 27, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
✨💫 Nice work Kaitlyn. I left some comments on space complexity. Let me know what questions you have.
🟢
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(log n) |
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(n) |
There was a problem hiding this comment.
🪐 You aren't creating any new data structures here or holding recursive calls in memory, so space complexity would be O(1)
| # Space Complexity: | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(n) | ||
| def add(self, key, value = None): |
| # Space Complexity: | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def find(self, key): |
|
|
||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder(self): |
| # Space Complexity: | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def preorder(self): |
| # Space Complexity: | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def postorder(self): |
| # Space Complexity: | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def height(self): |
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) |
There was a problem hiding this comment.
🪐 Space complexity is going to be O(n) here because your recursive calls will make a call for every node (every subtree) in the tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.