Conversation
kyra-patton
reviewed
Jul 28, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
Nice implementation, Lety! You are missing the time and space complexity for all but one of your functions, so I am marking this as a yellow. Let me know what questions you have.
🟡
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def add(self, key, value = None): |
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def find(self, key): |
| # Time Complexity: | ||
| # Space Complexity: | ||
|
|
||
| def inorder_helper_norecursion(self, current_node, trav_list): |
There was a problem hiding this comment.
🌟😎 Really cool you did it with both
Comment on lines
64
to
65
| # Time Complexity: | ||
| # Space Complexity: |
Comment on lines
103
to
104
| # Time Complexity: | ||
| # Space Complexity: |
Comment on lines
127
to
+128
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Space Complexity: |
|
|
||
| return trav_list | ||
|
|
||
| def preorder(self): |
| return trav_list | ||
|
|
||
|
|
||
| def postorder(self): |
Comment on lines
152
to
153
| # Time Complexity: | ||
| # Space Complexity: |
| else: | ||
| return 0 | ||
|
|
||
| def height (self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.