Cheetahs - Alexis Miller by LexElena22 · Pull Request #125 · Ada-C18/task-list-api

LexElena22 · 2022-11-10T19:18:38Z

No description provided.

jbieniosek

Great work on this project Alexis! This project is green based on the informal LP that we set up on 11/9, reducing the requirements to Waves 1-3.

jbieniosek · 2022-11-28T21:56:31Z

app/models/task.py

+    description = db.Column(db.String(2600))
+    completed_at = db.Column(db.DateTime, nullable=True)
+
+    def to_dict(self):


jbieniosek · 2022-11-28T21:56:50Z

app/routes.py

+
+
+#Validate
+def validate_task(task_id):


Great helper!

jbieniosek · 2022-11-28T21:58:19Z

app/routes.py

+    request_body = request.get_json()
+
+    if "title" not in request_body or "description" not in request_body:
+        return jsonify({"details": "Invalid data"}), 400


jbieniosek · 2022-11-28T22:00:17Z

app/routes.py

+    for task in tasks:
+        task_response.append(task.to_dict())
+
+    return jsonify(task_response)


Even though Flask will add the 200 for you, I recommend being explicit about the code everywhere, and not just in non 200 returns. Consistent formats make code easier to read.

Suggested change

return jsonify(task_response)

return jsonify(task_response), 200

jbieniosek · 2022-11-28T22:03:30Z

app/routes.py

+
+    task = validate_task(task_id)
+
+    return make_response({"task": task.to_dict()})


The function make_response isn't incorrect here, but I notice that some functions return jsonify and others return make_response. I recommend picking one format and using it throughout your code - having different formats that do the same thing can make it harder for someone reading your code to realize that the behavior is the same.

jbieniosek · 2022-11-28T22:05:04Z

app/routes.py

+def mark_complete(task_id):
+    task = validate_task(task_id)
+
+    task.completed_at = date.today()


jbieniosek · 2022-11-28T22:05:36Z

tests/test_wave_01.py

    # **Complete test with assertion about response body***************
    # *****************************************************************
-
+    assert response_body == {"message" : "Task ID '1' not found"}


LexElena22 added 2 commits November 2, 2022 13:55

Completed Setup

704560b

Wave 1-3 complete

4e4cea9

jbieniosek reviewed Nov 28, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cheetahs - Alexis Miller#125

Cheetahs - Alexis Miller#125
LexElena22 wants to merge 2 commits intoAda-C18:masterfrom
LexElena22:master

LexElena22 commented Nov 10, 2022

Uh oh!

jbieniosek left a comment

Uh oh!

jbieniosek Nov 28, 2022

Uh oh!

jbieniosek Nov 28, 2022

Uh oh!

jbieniosek Nov 28, 2022

Uh oh!

jbieniosek Nov 28, 2022

Uh oh!

jbieniosek Nov 28, 2022

Uh oh!

jbieniosek Nov 28, 2022

Uh oh!

jbieniosek Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return jsonify(task_response)
	return jsonify(task_response), 200


		task = validate_task(task_id)

		return make_response({"task": task.to_dict()})

Conversation

LexElena22 commented Nov 10, 2022

Uh oh!

jbieniosek left a comment

Choose a reason for hiding this comment

Uh oh!

jbieniosek Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

jbieniosek Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

jbieniosek Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

jbieniosek Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

jbieniosek Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

jbieniosek Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

jbieniosek Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants