Conversation
…ll with one entry works now
…fill_empties_with_defaults'. made is_complete default to False if nothing is entered for 'completed_at'
… endpoints working
…I want to save my progress just in case I'm on track.
…slack when a task is complete. all tests are still working.
CheezItMan
reviewed
Dec 4, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work. You hit the learning goals here. Well done. I left some minor comments in the code. If you have questions please ping me in Slack.
| "text": "Someone just completed the task " + task.title | ||
| } | ||
| headers = { | ||
| "Authorization" : "Bearer " + os.environ.get("SLACK_API_KEY") |
There was a problem hiding this comment.
The reason Learn is failing is that the Environment variable used by Learn is not named SLACK_API_KEY and so os.environ.get("SLACK_API_KEY") returns None.
| return make_response(response_body, 200) | ||
|
|
||
| #ideally, combine this with validate goal, passing in the class as well. | ||
| def validate_task(task_id): |
Comment on lines
+118
to
+119
| #can I make this a method for Tasks? | ||
| def update_given_values(task, request_body): |
There was a problem hiding this comment.
You can indeed make this a method in the tasks class. It would make a great helper method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.