Conversation
| <h2><%= @task.description %></h2> | ||
| <h3><%= @task.person%></h3> | ||
| <p> | ||
| <%= (@task.completed != nil) ? "completed: #{@task.completed}" : "incomplete" %> |
|
Great job with your first rails project! You did a great job organizing your code, and I love that you used both the rails conventions and custom methods to create a cohesive project. Lookout for consistent indentation in your HTML markup trying to do as much of the data processing as possible on the model/ controller and not in the view. Also please include a link to your project on Heroku in your PR so we can see your amazing code in action! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual project, TaskListRails is complete through all waves, with mediocre styling. I don't think I can identify any specific part that was a struggle, it was mildly sketchy all the way through.
I know my commit messages are totally useless for this project - I'm usually better about it but, I hate committing things that don't work and I sort of worked on everything at once until it worked, and then committed. I'm doing way better on our second Rails project, so please focus on actual content and not my shitty workflow/practices. Thanks! <3