Open
Conversation
…ll count uncompleted tasks
| @task.save | ||
| redirect_to root_path | ||
| end | ||
| end |
There was a problem hiding this comment.
The update_edit method looks good, but will look even better if you'll DRY your code.
you can move the ' @task = Task.find(params[:id]) ' => move before the 'if statement'
you can also move the :
@task.save
redirect_to root_path
out of the if statement, since you'll execute it anyway.
|
Your code is well written- Good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm happy that this works at all!!! I learned a lot about Rails (like - everything I know at this point) by doing this project. Good practice.
If I had more time, I'd like to go in and refactor/edit/streamline my code. But for now - I'm happy it works at all :)
Heroku: http://anna-tasks.herokuapp.com/