Conversation
| end | ||
| full_list += [current.value.to_s] | ||
| return p "Size is #{full_list.length}." | ||
| end |
There was a problem hiding this comment.
These looks generally good -- however, both methods are creating a side effect of printing something. If you are not asked to print something out, then you don't necessarily want to because it limits how you can use that method in the future.
I would expect that a method with a ? at the end would return a boolean and not print anything out.
I would also expect that a size method would only return a single numerical value and nothing else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.