Open
Conversation
| end | ||
| puts "The list does not include #{key}" | ||
| return false | ||
| end |
There was a problem hiding this comment.
yes! this looks nice! the only thing is that you shouldn't "puts" anything because I did not ask for that, which means that you are creating unintended side-affects for the method that may not be expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Crystal-this was a fun exercise and it took me another day or so to get max but I understand the pattern now. Had to add some puts statements and extra test elements to make sure it was returning what I thought it should be.
Thanks and hope your weekend is going great
Suze