Skip to content

Noelle Morris #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johnanmorris wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Noelle Morris #22

johnanmorris wants to merge 20 commits into from

Conversation

@johnanmorris
Copy link

@johnanmorris johnanmorris commented Aug 26, 2016 •
edited
Loading

Contains 5 Ruby files:

  • bank.rb : Module with Bank::Account and Bank::Owner
  • checking_account.rb : CheckingAccount class
  • savings_account.rb : SavingsAccount class
  • 2 test files: savings_test.rb (to test SavingsAccount) and checking_test (to test CheckingAccount)

Completed Optional Owner classes up to Wave 2

@johnanmorris
created Bank module with initialize, withdrawal, deposit methods
a8e15c0
@johnanmorris
Added Owner class with initialize method
7bed21e
@johnanmorris
Updated README for Wave 2
b74bf0d
@johnanmorris
Commented out Owner class and methods; they're not working. Changed @…
0e71bfc 
…acct_num to @id, and added @open_date to prep for CSV files.
@johnanmorris
Created bank_accounts.rb to test Bank methods.
6dd05fc
@johnanmorris
added methods self.all and self.find; deleted bank_accounts.rb
8116cec
@johnanmorris
Edited Owner class withinitialize variables matching CSV, added self.…
6989858 
…all and self.find
@johnanmorris
Attempt to write all_with_owners class method and add_owner instance …
4cfa46f 
…method. Failing.
@johnanmorris
Tried and failed again with adding owners to accounts.
865e3cb
@johnanmorris
Add CheckingAccount class inherited from Account parent class; implem…
e488419 
…ented different initialize and withdraw methods. Created bank_test.rb for testing class instances.
@johnanmorris
Partial implementation of withdraw_using_check. TODO: account for neg…
18e58fe 
…ative max overdraw.
@johnanmorris
Modified bank.rb with puts statements. Finished withdraw_using_check …
555b7a2 
…in CheckingAccount.
@johnanmorris
renamed bank_test to checking_test
3caead6
@johnanmorris
edited CheckingAccount withdraw method to use super
651a5cc
@johnanmorris
implemented add_interest method; implemented withdraw method
3bb7519
@johnanmorris
refactor checking_account withdraw method, added MIN_BALANCE constant…
966409c 
… in bank.rb and savings_account.rb
@johnanmorris
minor style edits
bc76b4c
@johnanmorris
undo changes to withdraw methods for CheckingAccount and SavingsAccount
1efde43
@johnanmorris
added self.all_with_owners and add_owner methods
bdc88c4
@johnanmorris
added savings_test.rb
9418ebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@johnanmorris