Open
Conversation
CheezItMan
reviewed
Dec 14, 2016
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Jessica,
not bad at all, good work with edit & delete.
Just a note, we normally have views only concern themselves with code inside that view, so to find code inside the view we can use it's internal jQuery object.
el.$
Overall nicely done.
| // el: $('#contact-cards'), <---still unsure why when el was specified (and direct li objects were added to ul tag), .contact-card tags could not be clicked independently | ||
| model: contact, //contacts created with each individual model passed through | ||
| }); | ||
| this.listenTo(card, "deetsplz", this.makeDetail); |
|
|
||
| addContact: function(contact) { | ||
| var card = new ContactView({ | ||
| // el: $('#contact-cards'), <---still unsure why when el was specified (and direct li objects were added to ul tag), .contact-card tags could not be clicked independently |
There was a problem hiding this comment.
Because when el was specified each view was encompassing the same area on the DOM so any event was triggering all their listeners.
| this.cardList.forEach(function(card) { | ||
| card.render(); | ||
| $('#contact-cards').append(card.$el); | ||
| }, this); |
There was a problem hiding this comment.
should be using el.$('#contact-cards').append, that way you're ensuring that the contact cards Id is within the view (el).
| var filteredList = []; | ||
| for(var i = 0; i < this.cardList.length; i++) { | ||
| if(this.cardList[i].model == model) { | ||
| console.log("Found the bugger!"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@CheezItMan