Open
Conversation
| var contactData = [ | ||
| { | ||
| name: 'Shari', | ||
| email: 'noshoes@gmail.com', |
There was a problem hiding this comment.
Serious LOLs with these e-mail addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished wave 1, wave 2, and most of wave 3. I didn't implement the removal of the modal from the page when any other part of the page is clicked upon. I also have to put all of the modal logic in contact view, and I understand that's not ideal because rolodex view should probably own that. I'd like some feedback on that situation. I wasn't here for the lectures on Monday and Tuesday, and had trouble catching up. I feel like I did a lot of copy and pasting from the live code, and then just changed variable names. A brief review of Backbone next week would be really helpful.