Open
Conversation
CheezItMan
reviewed
Dec 14, 2016
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad work, just a bit of messyness on how you're listening to events for the modal.
| 'click .contact-card': 'showModal' | ||
| }, | ||
| showModal: function() { | ||
| var detailsTemplate = _.template($('#tmpl-contact-details').html()); |
There was a problem hiding this comment.
This works and is fine here, but it's best practice to only render things within the view, not things outside the view.
I'd suggest a better method is triggering an event and responding to it in the Rolodex View.
| { | ||
| container.hide(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This works, but should be done with a Backbone view & not regular jQuery, but it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.