Skip to content

Wave two is complete#47

Open
BrandiPhillips wants to merge 7 commits intoAda-C6:masterfrom
BrandiPhillips:master
Open

Wave two is complete#47
BrandiPhillips wants to merge 7 commits intoAda-C6:masterfrom
BrandiPhillips:master

Conversation

@BrandiPhillips
Copy link

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good work Brandi! I like how you've commented to keep track of what's going on and you did a great job of implementing this project.

Nice work


// keep track of the elements that will be used to render the contact card and the contact details
this.listElement = this.$('#contact-cards');
this.detailsElement = this.$('#contact-details');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of this.$

'click .contact-card': 'showHandler'
},
showHandler: function(event){
this.trigger('showCardDetails', this.model);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent use of Trigger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants