Open
Conversation
I gotta name\!
Bmp collection - wave 2 complete
CheezItMan
reviewed
Dec 16, 2016
CheezItMan
left a comment
There was a problem hiding this comment.
This is really good work Brandi! I like how you've commented to keep track of what's going on and you did a great job of implementing this project.
Nice work
|
|
||
| // keep track of the elements that will be used to render the contact card and the contact details | ||
| this.listElement = this.$('#contact-cards'); | ||
| this.detailsElement = this.$('#contact-details'); |
| 'click .contact-card': 'showHandler' | ||
| }, | ||
| showHandler: function(event){ | ||
| this.trigger('showCardDetails', this.model); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@CheezItMan