Ashton's Bank Account

[ashtn]

Bank Account

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
Why is it useful to put classes inside modules? What do you think?	It's a good way to contain your Class elements, if you are using multiple classes.
What is accomplished with raise ArgumentError? What do you think it's doing?	I think raise ArgumentError is some kind of conditional string method, that prints a message to the screen if specific criteria is or isn't met.
Why do you think we made the .all & .find methods class methods? Why not instance methods?	Because the information we were looking for was not about 1 specific instance of a class, also it was a great way to pass those methods on to the sub classes.
Why does it make sense to use inheritance for the different types of accounts?	Because all accounts in this example inherently had similar functionality, and with was more efficient to make methods for a parent, and pass them on to the child class, rather than writing all new methods for each type of account.
Did the presence of automated tests change the way you thought about the problem? How?	While the tests were pre populated, it was very restrictive in how i could think about bank accounts. I also think in theory it would help catch mistakes before they happen, but that didn't happen for me this time.

[CheezItMan]

Overall nicely done, I put a few comments into the code here and there, but you did well.

[CheezItMan]

This should instead be triggering an ArgumentError

[CheezItMan]

You should be able to call the withdraw method from within check_withdraw.

[CheezItMan]

Bank Account

What We're Looking For

Feature	Feedback
Wave 1
All provided tests pass	Check
Using the appropriate attr_ for instance variables	Done, nice use of the hash in initialize
Wave 2
All stubbed tests are implemented fully and pass	Done, good use of the CSV in testing
Created instances (by calling new) in Account.all	Done
Used CSV library only in Account.all (not in Account.find)	Done, interesting use of the class variable
Used Account.all to get account list in Account.find	Used a class variable instead, good idea!
Wave 3
All stubbed tests are implemented fully and pass	Done
Used inheritance in the initialize for both Checking and Savings Accounts (min balance)	done
Used inheritance for the withdraw in checking and savings accounts	Done with super great!
Baseline
Used Git Regularly	Lots of regular commits
Answer comprehension questions	Modules: It also will namespace your code to prevent clashes from classes with the same name. ArgumentError causes the method to exit with an error that the calling code will need to handle. It keeps your code from executing with invalid arguments. Otherwise good answers.

Summary

Overall nicely done, I put a few comments into the code here and there, but you did well.

[ashtn]

Yay! Thanks Chris!

…

On Tue, Feb 28, 2017 at 11:25 AM, Chris M ***@***.***> wrote: ***@***.**** commented on this pull request. Overall nicely done, I put a few comments into the code here, but you did well. ------------------------------ In specs/checking_account_spec.rb <#31 (comment)>: > end it "Doesn't modify the balance if the account would go below -$10" do - # TODO: Your test code here! + @account.check_withdraw(200).must_equal 100 end it "Requires a positive withdrawal amount" do This should instead be triggering an ArgumentError ------------------------------ In lib/checking.rb <#31 (comment)>: > + end + + + def withdraw(amount) + + if @balance - (amount + 1) < 1 + print "Insufficient Funds" + return @balnace = @balance + end + super + return @balance -= 1 + + end + + + def check_withdraw(amount) You should be able to call the withdraw method from within check_withdraw. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATT5oohC13qUVnqr3Yu1rwaVyKnfnGC8ks5rhHSfgaJpZM4MMzzo> .