Skip to content

Jackie - Calculator Assignment#22

Open
jackiewatanabe wants to merge 1 commit intoAda-C7:masterfrom
jackiewatanabe:master
Open

Jackie - Calculator Assignment#22
jackiewatanabe wants to merge 1 commit intoAda-C7:masterfrom
jackiewatanabe:master

Conversation

@jackiewatanabe
Copy link

@jackiewatanabe jackiewatanabe commented Feb 10, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I stored user inputs by using gets.chomp and storing them into variables number1 and number2
How did you determine what operation to perform? I determined what operations to perform by asking for user inputs and using case/when to compare the inputs to specific strings
Do you feel like you used consistent indentation throughout your code? yes
If you had more time, what would you have added to or changed about the program? I would have added conditions for if a user input something other than numbers and also added a feature to calculate answer with floats

I guess I totally overlooked the test/verify section and I didn't realize it was a requirement to make sure to put in code to verify the user put in a valid number... I also didn't do the part to account for when a user wants to divide by zero.

@jackiewatanabe jackiewatanabe changed the title saved my calculator assignment Jackie - Calculator Assignment Feb 10, 2017
@kariabancroft
Copy link

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. done
Baseline
Readable code with consistent indentation. Yes, done

Summary

Nice work building methods to display the results of the operations. Is there a way to write a single method that does it all to avoid such repetition of code? Maybe build a method to output the result no matter the operator.

Overall nice work!

Reviewed by Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants