Skip to content

Create Queues_Allison_Northrop_Calculator#41

Open
Allison-Northrop wants to merge 1 commit intoAda-C7:masterfrom
Allison-Northrop:master
Open

Create Queues_Allison_Northrop_Calculator#41
Allison-Northrop wants to merge 1 commit intoAda-C7:masterfrom
Allison-Northrop:master

Conversation

@Allison-Northrop
Copy link

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I stored user input in a variable. The data type was a string.
How did you determine what operation to perform? Based on what the user enter (for example "add" or "+") I tied the answer to the corresponding method. So, if a user input "/" or "divide", the program would use the divide method.
Do you feel like you used consistent indentation throughout your code? For the most part, but in hindsight, I should have not indented the "solution" variables (after each method)
If you had more time, what would you have added to or changed about the program? I would have taken into account if the user input "nine" instead of "9". I also would take into account if there were extra spaces, etc.

@kariabancroft
Copy link

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Well done
Baseline
Readable code with consistent indentation. Close, as you mentioned, lines 14, 19, 24 and 29 do not need to be indented
Extras
Functionality I was able to input 'sdf + 3 and got back 3.0
Lines 14, 19, 24 and 29 (the lines after the methods) are not necessary. Methods can be called directly in the conditional. Otherwise every single one of these methods is going to be ran, even when not needed.
Remember to save file in github with .rb extension so that syntax highlighting is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants