Skip to content

Queues - Anna Barklund - Create calculator.rb#44

Open
amb54 wants to merge 1 commit intoAda-C7:masterfrom
amb54:master
Open

Queues - Anna Barklund - Create calculator.rb#44
amb54 wants to merge 1 commit intoAda-C7:masterfrom
amb54:master

Conversation

@amb54
Copy link

@amb54 amb54 commented Feb 10, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? Into variables
How did you determine what operation to perform? Compared the input for the operator to an array of valid operators.
Do you feel like you used consistent indentation throughout your code? Yes. Unsure about how to handle case. The indentation check pulled it back again (??)
If you had more time, what would you have added to or changed about the program? I would have liked to be able to handle an input like: 10 * (2+4)

@kariabancroft
Copy link

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Well Done
Baseline
Readable code with consistent indentation. Well Done. (While the case statement is okay, it can be more readable by putting the code to be executed on a new, indented line below the condition - instead of using then. If using then, here's an example of how to still use it without having to repeat 'result =' on ever line. http://www.techotopia.com/index.php/The_Ruby_case_Statement)
Extras
Functionality Nice handling of entering 0 for division, like that it loops back to the start of the program. Nice way to handle checking for float and integer. Great use of data structures as return values!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants