Skip to content

Queues - Hyunji Kim - Calculator#46

Open
ricecakemonster wants to merge 3 commits intoAda-C7:masterfrom
ricecakemonster:master
Open

Queues - Hyunji Kim - Calculator#46
ricecakemonster wants to merge 3 commits intoAda-C7:masterfrom
ricecakemonster:master

Conversation

@ricecakemonster
Copy link

@ricecakemonster ricecakemonster commented Feb 10, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? stored in variables
How did you determine what operation to perform? depending on what user entered. add or + would be +
Do you feel like you used consistent indentation throughout your code? I think so..
If you had more time, what would you have added to or changed about the program? I like to make it calculate long formulas.

@kariabancroft
Copy link

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Well Done
Baseline
Readable code with consistent indentation. Well Done
Extras
Methods Good start, would like to see more methods used in this program. What chunks of code to be wrapped in a method to give more context to what it is doing? For example, lines 9-12 could be wrapped up in a method with a name that is explicit about what it's doing, like 'validate_operator'.
Nice way to identify is_integer? as a repeated chunk of code, works very well as a method. t Great job with using the '?' with a method that only returns true or false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants