Skip to content

Queues - Tamiko Terada - calculator.rb#48

Open
TamikoT wants to merge 3 commits intoAda-C7:masterfrom
TamikoT:master
Open

Queues - Tamiko Terada - calculator.rb#48
TamikoT wants to merge 3 commits intoAda-C7:masterfrom
TamikoT:master

Conversation

@TamikoT
Copy link

@TamikoT TamikoT commented Feb 10, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I first tried to store the user input as one expression of "num1 operator num 2" but I ran into lots of problems with trying to parse and validate the original string so I eventually decided to get and store as 3 separate variables from the user.
How did you determine what operation to perform? I set up a method for my operations that included cases depending on what the user entered.
Do you feel like you used consistent indentation throughout your code? I hope so...!
If you had more time, what would you have added to or changed about the program? I would try to pursue the entering as one expression thing a little more from 1.

@kariabancroft
Copy link

Calculator

What We're Looking For

Feature Feedback                                                                              
Takes in two numbers and an operator and performs the mathematical operation. Well done
Baseline
Readable code with consistent indentation. Well Done
Extras Great use of methods and using best practices. Remember with methods that return true or false, like valid operator, method name should have '?'.
Very clean case statement. Nice user interface in terminal, good use of methods name to make code more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants