Pipes - Sarah and Lindsey - VideoStoreAPI

[SRBusiness]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We looked at the project requirements, the seed data, and the optionals and discussed what type of relationships we thought would best suit out project. Then we white boarded, built it and made a lucid chart.
Describe a set of positive and negative test cases you implemented for a model.	For the movies model relationships we tested that relationships existed between rentals and customers even when a movie didn't have a specific instance of those.
Describe a set of positive and negative test cases you implemented for a controller.	For the movies controller show action we tested the positive case and the negative case and ensured that is had the proper json and error handling.
How does your API respond when bad data is sent to it?	it sends a bad_response status code as well as json error messages that describe the error you triggered.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We made a custom model method for the movies model called set_available_inventory, we combined this with a callback function so that when a movie was created it set the value of available inventory to the value of inventory.
Do you have any recommendations on how we could improve this project for the next cohort?	This week and project was very easy, if that was the intent that don't change anything. Otherwise you could make the first set of optional required.
Link to Trello	This project was so small we didn't use trello and relied on slack and in person communication to manage task.
Link to ERD	https://www.lucidchart.com/invitations/accept/421b6d9a-5df0-4acd-8f48-6953136bba78

[PilgrimMemoirs]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Well Done
General
Business Logic in Models	Well Done - If a method is returning a boolean, like can_rent, it's conventional in ruby to have a question mark at the end of the method name.
All 3 required endpoints return expected JSON data	Well Done
Requests respond with appropriate HTTP Status Code	Well Done
Errors are reported	Well Done
Testing
Passes all Smoke Tests	Well Done
Model Tests - all relations, validations, and custom functions test positive & negative cases	Well Done
Controller Tests - URI parameters and data in the request body have positive & negative cases	Mostly Good - custom model method for customer only has one test, make sure to have a negative and/or edge case tests for any custom methods
Optionals
POST routes use URI parameter and request body to add a new record to the database
GET /customers shows how many movies are checked out by a customer	Well done
GET /movies/:id shows updated inventory	Well Done
Overall
	Submission meets project expectations, well done!