Open
Conversation
Video StoreWhat We're Looking For
|
1 similar comment
Video StoreWhat We're Looking For
|
| ) | ||
| else | ||
| render json: {nothing: true}, status: :not_found | ||
| end |
There was a problem hiding this comment.
This will literally send back { nothing: true } as a JSON response. Not sure that's what you intended.
|
|
||
| def customer_params | ||
| params.require(:customer).permit(:id, :name, :registered_at, :address, :city, :state, :postal_code, :phone, :account_credit, :movies_checked_out_count) | ||
| end |
There was a problem hiding this comment.
You shouldn't need to define strong params if you don't have a create or update action. As far as I can tell this method is never called.
| # | ||
| ======= | ||
|
|
||
| >>>>>>> d895f891acf50da64888798d075b4c23e843b99f |
There was a problem hiding this comment.
Why are there git merge markers in this file?
There was a problem hiding this comment.
If missing these markers is a regular problem for you, you might want to set up a pre-commit hook:
https://jondowdle.com/2015/02/block-merge-conflicts-in-commits/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video Store API
Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Comprehension Questions