Roxanne Agerone and Kimberley Zell - Pipes - VideoStoreConsumer#22
Open
kimpossible1 wants to merge 50 commits intoAda-C8:masterfrom
Open
Roxanne Agerone and Kimberley Zell - Pipes - VideoStoreConsumer#22kimpossible1 wants to merge 50 commits intoAda-C8:masterfrom
kimpossible1 wants to merge 50 commits intoAda-C8:masterfrom
Conversation
Signed-off-by: Kimberley Zell <kimberley.zell@gmail.com>
…ything, as well as code we are not using and not going to use.
…thout a title and release date
Video Store ConsumerWhat We're Looking For
|
droberts-sea
reviewed
Jan 5, 2018
|
|
||
| add(newMovie) { | ||
| if(!newMovie.isValid()){ | ||
| $('.display-status').html('') |
There was a problem hiding this comment.
This function seems a little strange to me. It's defined on Movie, which implies you're currently inside a movie object, but it requires you to pass in a separate movie object and saves that to the database. Instead, it would probably be cleaner to have this function save this movie to the API, and call it on the new movie instead of the old.
Alternatively, you could say it's called on the old movie, but internally does the work of creating a new movie and saving that (work that is currently done in MovieView.add())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video Store Consumer
Congratulations! You're submitting your assignment!
Comprehension Questions