Carets- Julia Meier- API Muncher by julmeier · Pull Request #25 · Ada-C8/api-muncher

julmeier · 2017-11-06T07:24:57Z

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I experimented with Postman to query the API. It also helped to read through the documentation. Once creating my api_wrapper class and recipe class, I experimented some more on how to best query the API.
Describe your API Wrapper. How did you decide on the methods you created?	The API Wrapper class has methods that constructs the API url needed to return either a collection of recipes or a single recipe, and corresponding methods to create ruby objects from the received API recipe data. I also have a method that just returns the number of recipes in the Edamam API for a give keyword search.
Describe an edge case or failure case test you wrote for your API Wrapper.	One test makes sure that a bogus request (ex. "jklmnopqrstuv" in the search bar) will return an empty array.
Explain how VCR aids in testing an API.	A VCR records an application's interaction with an HTTP request. It is helpful in testing APIs because the interaction can be called and recorded only once. Tests can use this recording without making more calls to the API. This is helpful if there is a limit on the number of API calls (for example, Edamam only allows 5 per minute, which would make controller testing difficult) or the API calls are expensive. It also allows programmers to test offline.
What is the Heroku URL of your deployed application?	http://hidden-woodland-83927.herokuapp.com/

…ade env file and added file to gitignore

…er the class that was messing up the CVR

…able to render a list of search results

…he from and to parameters

…ith how to inject the from/to into the params

…ut to start writing tests on the edamam_api to see why it's returning an empty array for the list_recipes method

…params and making a new path

…nly gives 100 recipes at a time. Also made show controller

…ller methods and then deploy to heroku

…he number_of_recipes is <10, 10-100, or greater than 100

…error

… Gale's advice

…ause heroku believes the @number_of_recipes is nil

…messing up heroku

…apping header background image

…ta still doesn't line up correctly

…dded two lines to production.rb per stackoverflow heros

… a large white gap between the image and the footer

…sting

…ib tests

CheezItMan · 2017-11-06T21:08:33Z

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Lots of commits, good mesages
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)
Semantic HTML	Reasonable semantic HTML, you do have some `div` elements which are there for styling, that could be replaced or dropped and the semantic tags used instead..
Errors are reported to the user	Flash notices if they didn't search for anything.
API Wrapper to handle the API requests	Check
Controller testing	Tests written, but not working, You did have the postgres problem earlier.
Lib testing	Check
Search Functionality	Work great!
List Functionality	Well done!
Show individual item functionality (link to original recipe opens in new tab)	This is missing.
Styling
Foundation Styling for responsive layout	Check
List View shows 10 items at a time/pagination	Well done
The app is styled to create an attractive user interface	Nicely styled
API Features
The App attributes Edaman	Check
The VCR casettes do not contain the API key	Check
External Resources
Link to Trello Board	NA
Link to deployed app on Heroku	Well done
Overall	Nicely done, you recovered well from the Postgres problem after I showed you how to fix it. Pretty good testing and nice styling. Well done.

CheezItMan · 2017-11-06T20:42:51Z

test/controllers/recipes_controller_test.rb

+      end
+    end
+
+    describe "search by page (i.e. pagination)" do


Good sets of tests.

CheezItMan · 2017-11-06T21:01:57Z

test/controllers/recipes_controller_test.rb

+      it "redirects to the home page if the user enters nothing as a keyword" do
+        get recipes_search_path params:{keywords: ""}
+        must_redirect_to root_path
+        flash[:failure].must_equal "You did not enter any keywords. Please enter ingredient keywords into the search bar."


Your controller doesn't actually add that flash message.

CheezItMan · 2017-11-06T21:02:13Z

app/controllers/recipes_controller.rb

+      #binding.pry
+      @keywords = params['keywords']
+      if @keywords.blank?
+        redirect_to root_path


no flash notice?

…nding page

…changed position from absolute to relative)

julmeier added 30 commits November 1, 2017 13:58

initial setup. copied lib and lib_test files from previous project. m…

43689ef

…ade env file and added file to gitignore

added recipes_controller

b2d35cc

added config.autoload_paths line to the config/application.rb file

86dde1e

continued testing of edamam_api_wrapper. Found some leftover text aft…

b3d54f1

…er the class that was messing up the CVR

created controller methods and made index and search html pages. Was …

17fea3b

…able to render a list of search results

made show controller, route and view

7b7cb33

created show_recipe method. modified list_recipes method to take in t…

96a423f

…he from and to parameters

save of number_of_recipes/10 loop in the search view. experimenting w…

86d29f0

…ith how to inject the from/to into the params

figured out how to pass the from/to parameters to the controller. Abo…

5d36257

…ut to start writing tests on the edamam_api to see why it's returning an empty array for the list_recipes method

some nuggets of wisdom from dee about how to inject from/to into the …

a7e2304

…params and making a new path

got help from dee to finish with pagination. found out that the API o…

48e4dd3

…nly gives 100 recipes at a time. Also made show controller

added additional elements to show page. will start to refactor contro…

b81cdc9

…ller methods and then deploy to heroku

added logic to search view to display the pagination correctly when t…

cb93b6f

…he number_of_recipes is <10, 10-100, or greater than 100

additional refactoring

d9a40cf

commented out require stuff at the top of controllers

8484a07

changed line 12 in search.html to consider nil class based on heroku …

2a57fd1

…error

added required lines to the application.rb and production.rb based on…

dae937d

… Gale's advice

changed line 12 in search view to be &&

737276d

removed the portion of the view page that displays the pagination bec…

a533fe2

…ause heroku believes the @number_of_recipes is nil

added back in the pagination view code. Took it out to see if it was …

6e27d54

…messing up heroku

added require dependency to the API controller too

2401968

added styling to the form and search pages. having issue oissue of wr…

cf5b4c4

…apping header background image

continued styling on show and search pages. The Health Information da…

f0208ef

…ta still doesn't line up correctly

can't get the photo captions to wrap

2a3f897

fixed columns on the show page so that all content lines up correctly

a5b9107

heroku is not uploading my background image for the search headers. a…

86650bd

…dded two lines to production.rb per stackoverflow heros

removed config.assets.compile = false from production.rb

fc33205

finished all required styling

b236ded

centered grid on results page. on an xlarge screen, the home page has…

823c83a

… a large white gap between the image and the footer

tried to fix gap between footer and image on home page- no go

3fda7b6

julmeier added 7 commits November 5, 2017 11:31

changed name to What's Cookin'?

868b12d

fixed CSS mistakes that were preventing upload to heroku

d628354

controller testing ongoing. saving because computer is getting blippy

5f1550b

changed failure case from @keywords.nil? to @keywords.blank? after te…

f5fe8d5

…sting

additional controller tests

29bbac7

additional model and controller testing

f4f1af7

Chris helped me get lib tests to work by recreating postgres. Fixed l…

d86e89f

…ib tests

CheezItMan reviewed Nov 6, 2017

View reviewed changes

julmeier added 2 commits November 13, 2017 16:05

changed CSS body to 100% height which fixed smartphone issues with la…

25d67ab

…nding page

changed footer CSS on results page so that it's fixed to the bottom (…

8d869b2

…changed position from absolute to relative)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Carets- Julia Meier- API Muncher#25

Carets- Julia Meier- API Muncher#25
julmeier wants to merge 39 commits intoAda-C8:masterfrom
julmeier:master

julmeier commented Nov 6, 2017

Uh oh!

CheezItMan commented Nov 6, 2017

Uh oh!

CheezItMan Nov 6, 2017

Uh oh!

CheezItMan Nov 6, 2017

Uh oh!

CheezItMan Nov 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

julmeier commented Nov 6, 2017

API Muncher

Comprehension Questions

Uh oh!

CheezItMan commented Nov 6, 2017

API Muncher

What We're Looking For

Uh oh!

CheezItMan Nov 6, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Nov 6, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Nov 6, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants