Stef -- Carets by SesameSeeds · Pull Request #27 · Ada-C8/api-muncher

SesameSeeds · 2017-11-06T10:39:24Z

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I used a combination of Postman and the console, this particularly came in handy to test to make sure I was pulling the correct information.
Describe your API Wrapper. How did you decide on the methods you created?	I kept it simple, by using Postman and knowing I did not (in my mind) need more than two methods I focused on the main methods to list and show. I pulled the information as needed/required from the hashes, focusing on the idea of key, value pair. You can read more about this in my API Wrapper comments, there is a comment for each method with further detail.
Describe an edge case or failure case test you wrote for your API Wrapper.	I did not write anything fancy, just one test that returns an empty array if no search word is provided, as well as, a test that returns nil for an invalid uri.
Explain how VCR aids in testing an API.	Simply put, particularly in this application where you have a limitation to how many 'hits' you can make... The VCR 'records' your tests and saves them in appropriately labeled cassettes for future testing use which is great in the sense where you can test with the information that is saved and not continually drag down on your API search limit.
What is the Heroku URL of your deployed application?	https://trinom.herokuapp.com/

…s, and added recipe file to lib and updated.

…to testing, and updated.

…llenge evidently...

…ome page and add search bar across all pages.

…eceiving this error, but wrote tests.

CheezItMan · 2017-11-06T16:27:51Z

test/test_helper.rb

@@ -0,0 +1,9 @@
+require File.expand_path('../../config/environment', __FILE__)
+require 'rails/test_help'


You're missing the VCR setup. You can see that here:

Thank you! Sorted that!

CheezItMan · 2017-11-06T17:08:42Z

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Reasonable number of commits, good commit messages.
Comprehension questions	Check, well done
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Good semantic HTML.
Errors are reported to the user	If the API isn't working no report is given to the user, it's just an empty list of recipes.
API Wrapper to handle the API requests	Check
Controller testing	Tests are written, but many are erroring out. Now however some are passing.
Lib testing	Tests written for your class, but no negative-cases and many don't work.
Search Functionality	Works great
List Functionality	Works well.
Show individual item functionality (link to original recipe opens in new tab)	Check
Styling	Looks very nice
Foundation Styling for responsive layout	The item layout was responsive
List View shows 10 items at a time/pagination	Pagination is working now
The app is styled to create an attractive user interface	Very nice styling.
API Features
The App attributes Edaman	Check
The VCR casettes do not contain the API key	Check!
External Resources
Link to deployed app on Heroku	Check, works well
Overall	You hit most of the requirements. The major requirement missed was testing. This is something you need to work on with your tutor or find me this week and we'll walk through it. This project was encouraging, but do your best this week and next to get as much done during project time rather than try to catch up on the weekend. Having people nearby who can answer questions will really help.

CheezItMan · 2017-11-06T16:30:04Z

test/lib/recipe_test.rb

+    recipe.ingredients.must_equal "ingredients"
+    recipe.dietary.must_equal "dietary"
+    recipe.link.must_equal "link"
+  end


I would also add a test to verify any required fields. Basically a negative test for the initialize method.

CheezItMan · 2017-11-06T16:34:40Z

Gemfile

+
+group :test do
+  gem 'minitest-rails'
+  gem 'minitest-reporters'


Also missing VCR and webmock

exit

CheezItMan · 2017-11-07T16:39:41Z

test/lib/edamam_api_wrapper_test.rb

+      VCR.use_cassette("recipes") do
+        good_uri = "https://api.edamam.com/search?r=http://www.edamam.com/ontologies/edamam.owl%23recipe_c23d4d64e02318eef70940c6643353ad"
+        recipe = EdamamApiWrapper.show_recipe(good_uri)
+        recipe.label.must_equal 'Pimento Cheese'


No field called label

CheezItMan

I took a look at things again, you've got some running tests now, but many are throwing errors or failing. Just some cleanup work to do there. I also updated my feedback above.

CheezItMan · 2017-11-07T16:41:18Z

lib/edamam_api_wrapper.rb

+
+    url = BASE_URL + "r=" + RECIPE_URL + (recipe_uri)
+
+    data = HTTParty.get(url)


You probably need a test to see if data is nil, or data[0] is nil before trying to create a recipe object.

CheezItMan · 2017-11-07T16:46:43Z

test/controllers/recipes_controller_test.rb

+    it "Shows a recipe page for a recipe." do
+      VCR.use_cassette("recipes") do
+        recipe = "https://api.edamam.com/search?r=http://www.edamam.com/ontologies/edamam.owl%23recipe_c23d4d64e02318eef70940c6643353ad"
+        get recipe_path(uri: recipe)


This should probably be something like this:
get recipe_path(recipe)

But I think the above URI is wrong.

SesameSeeds · 2017-11-07T23:24:49Z

Tests now passing completely, with a few more added tests.
Flash messages added and working!
I believe minus adding some OAuth, this looks pretty damn good.

… footer.

CheezItMan

Really good, now the focus needs to be on VideoStore and crafting an API, and over the weekend reading up on JavaScript

CheezItMan · 2017-11-08T18:14:24Z

test/lib/edamam_api_wrapper_test.rb

+describe EdamamApiWrapper do
+
+  describe "self.list_recipes" do
+    it "Can get recipes with a search word." do


The only other thing for this would be verifying that each element of the array is a Recipe. Otherwise really good.

We did get our project done for VideoStore and turned it in this afternoon. I'm working on JS now. :) . Thank you for the feedback, I really appreciate it.

SesameSeeds added 26 commits October 31, 2017 17:40

Initial Commit.

f3efb6f

Gem better_errors added.

e419b6f

.ENV created, added to .gitignore, and api wrapper started.

01397c7

Addition of recipes controller.

f63896a

Added routes, updated api_wrapper, started controller pseudocode test…

404fa24

…s, and added recipe file to lib and updated.

Move app/channels/assets to app/assets

04aa27d

Fixed foundation version, installed (thanks Charles), added lib file …

4e423ff

…to testing, and updated.

Updated API wrapper to get list of recipes.

20cc1eb

Finished list method, working on show method.

6893fc8

Updated self method, still recieving error.

669b34e

Updated show method with encode.

3d9e509

Show method now working, yay.

7cc82de

Working on controller and views, added favicon.

e6cbfc4

Working through creating tests.

ada5c0f

Updated controller to reflect 10 not 12 items, reading is still a cha…

e7a18ad

…llenge evidently...

Controller updated with proper methods being called.

5357d03

Working with views, currently too large to render...

bdfb375

List view in progress, now showing photos.

92e1bd8

Updated params and show views. Basic things now working on all paths.

5c9fa0b

Views complete and working.

ab727d2

Removed home page, updated application.html.erb to reflect needs of h…

bb0521a

…ome page and add search bar across all pages.

Creation of logo, re-addition of placeholder home page due to errors.

ccd8aae

Some styling added.

399ce7a

Tests written but database failure, unsure if they pass or why I am r…

c1e4f75

…eceiving this error, but wrote tests.

Very basic styling done.

5e77332

Small updates.

4eeeb28

CheezItMan reviewed Nov 6, 2017

View reviewed changes

Testing gems and missing info added to run tests.

6aea894

CheezItMan reviewed Nov 6, 2017

View reviewed changes

SesameSeeds added 9 commits November 6, 2017 14:58

Pagination is now working.

15ff149

exit

Update to API Wrapper.

3b928f7

Removed unnecessary divs to make html more semantic.

5b3dd5e

Footer now on bottom properly on every page.

2910d97

Minor styling updates.

b80c3cf

Styling nearly finished.

a64215a

Link update.

d962729

Link update.

428eeb2

More changes for heroku push.

f8f645f

CheezItMan reviewed Nov 7, 2017

View reviewed changes

SesameSeeds added 3 commits November 7, 2017 14:44

All tests passing for APIWrapper and Recipe lib.

7ba3227

All tests passing.

6046f0f

Errors/Flash messages working.

86fdfa8

Another test added, simplecov added, 100% passing, still messing with…

37c6423

… footer.

CheezItMan reviewed Nov 8, 2017

View reviewed changes

		@@ -0,0 +1,9 @@
		require File.expand_path('../../config/environment', __FILE__)
		require 'rails/test_help'


		url = BASE_URL + "r=" + RECIPE_URL + (recipe_uri)

		data = HTTParty.get(url)

Conversation

SesameSeeds commented Nov 6, 2017

API Muncher

Comprehension Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CheezItMan commented Nov 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Muncher

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CheezItMan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SesameSeeds commented Nov 7, 2017

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CheezItMan commented Nov 6, 2017 •

edited

Loading

CheezItMan left a comment •

edited

Loading