Open
Conversation
CalculatorWhat We're Looking For
|
CheezItMan
reviewed
Feb 9, 2018
|
|
||
| # Program for calculator. | ||
| puts " Welcome to the calculator " | ||
| operators_array = %w[add + subtract - divide / multiply * % ^] |
|
|
||
| # To know when it needs to return an _integer_ versus a _float_. | ||
| def convert_i_f(value) | ||
| if (value =~ /\./) |
There was a problem hiding this comment.
This checks to see it if has ANY decimals in it. So the user could enter two of them, more detection of an invalid value would be better.
For example 3...1 is accepted
| while flag | ||
| puts "Enter the first number " | ||
| num1 = gets.chomp | ||
| if (num1 =~ /[a-zA-Z]/) |
There was a problem hiding this comment.
This only checks for letters (a-z), not punctuation for example.
| # To check whether the user input is numeric for second number | ||
| flag = true | ||
| flag = true | ||
| while flag |
There was a problem hiding this comment.
notice how this section is a repeat of above... great candidate for a method!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions