Conversation
CalculatorWhat We're Looking For
Lovely calculator! Functions wonderfully Your custom methods ( Your loops are great! They work perfectly for waiting for correct user input, and ESPECIALLY the times loop in the case of operation being exponent. I'm surprised you went with I think overall, good, clean, functional code I'm commenting on two places in the code where the indentation was off just for your information Also, you didn't handle dividing by zero |
tildeee
reviewed
Feb 12, 2018
| until possible_operations.include?(operation) | ||
| puts "That is an invalid operation. Try again" | ||
| operation = gets.chomp.upcase | ||
| end |
tildeee
reviewed
Feb 12, 2018
| while num_one.to_i.to_s != num_one | ||
| puts "That is not a valid number. Please try again." | ||
| num_one = gets.chomp | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions